UNDO THIS COMMIT

gabrieldonadel · Aug 19, 2022 · c57ae1c · c57ae1c
1 parent 5c8e011
commit c57ae1c
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 0 deletions.
diff --git a/Libraries/NativeComponent/BaseViewConfig.android.js b/Libraries/NativeComponent/BaseViewConfig.android.js
@@ -212,6 +212,7 @@ const validAttributesForNonEventProps = {
   marginStart: true,
   marginEnd: true,
   marginTop: true,
+  // marginBlockStart: true,
   marginBottom: true,
   marginLeft: true,
   marginRight: true,

diff --git a/Libraries/NativeComponent/BaseViewConfig.ios.js b/Libraries/NativeComponent/BaseViewConfig.ios.js
@@ -248,6 +248,7 @@ const validAttributesForNonEventProps = {
   // borderEndWidth: true,
   // borderWidth: true,
 
+  // marginBlockStart: true,
   marginTop: true,
   marginRight: true,
   marginBottom: true,

diff --git a/Libraries/StyleSheet/StyleSheetTypes.js b/Libraries/StyleSheet/StyleSheetTypes.js
@@ -189,6 +189,12 @@ type ____LayoutStyle_Internal = $ReadOnly<{
    */
   marginBottom?: DimensionValue,
 
+  /** `marginBlockStart` works like `margin-bottom` in CSS.
+   *  See https://developer.mozilla.org/en-US/docs/Web/CSS/margin-bottom
+   *  for more details.
+   */
+  marginBlockStart?: DimensionValue,
+
   /**
    * When direction is `ltr`, `marginEnd` is equivalent to `marginRight`.
    * When direction is `rtl`, `marginEnd` is equivalent to `marginLeft`.

diff --git a/Libraries/StyleSheet/splitLayoutProps.js b/Libraries/StyleSheet/splitLayoutProps.js
@@ -30,6 +30,7 @@ export default function splitLayoutProps(props: ?____ViewStyle_Internal): {
         case 'marginVertical':
         case 'marginBottom':
         case 'marginTop':
+        // case 'marginBlockStart':
         case 'marginLeft':
         case 'marginRight':
         case 'flex':

diff --git a/React/Views/RCTShadowView.h b/React/Views/RCTShadowView.h
@@ -123,6 +123,7 @@ typedef void (^RCTApplierBlock)(NSDictionary<NSNumber *, UIView *> *viewRegistry
 @property (nonatomic, assign) YGValue marginBottom;
 @property (nonatomic, assign) YGValue marginRight;
 @property (nonatomic, assign) YGValue marginStart;
+// @property (nonatomic, assign) YGValue marginBlockStart;
 @property (nonatomic, assign) YGValue marginEnd;
 
 /**

diff --git a/React/Views/RCTShadowView.m b/React/Views/RCTShadowView.m
@@ -30,6 +30,7 @@ typedef NS_ENUM(unsigned int, meta_prop_t) {
   META_PROP_VERTICAL,
   META_PROP_ALL,
   META_PROP_COUNT,
+  // META_PROP_BLOCK_START
 };
 
 @implementation RCTShadowView {
@@ -133,11 +134,17 @@ static void RCTProcessMetaPropsMargin(const YGValue metaProps[META_PROP_COUNT],
     RCT_SET_YGVALUE_AUTO(start, YGNodeStyleSetMargin, node, YGEdgeStart);
     RCT_SET_YGVALUE_AUTO(end, YGNodeStyleSetMargin, node, YGEdgeEnd);
   }
+
+    NSLog(@"testee");
+//  if(metaProps[META_PROP_BLOCK_START].unit == YGUnitUndefined){
+//      NSLog(@"Caraiiiii");
+//  }
   RCT_SET_YGVALUE_AUTO(metaProps[META_PROP_TOP], YGNodeStyleSetMargin, node, YGEdgeTop);
   RCT_SET_YGVALUE_AUTO(metaProps[META_PROP_BOTTOM], YGNodeStyleSetMargin, node, YGEdgeBottom);
   RCT_SET_YGVALUE_AUTO(metaProps[META_PROP_HORIZONTAL], YGNodeStyleSetMargin, node, YGEdgeHorizontal);
   RCT_SET_YGVALUE_AUTO(metaProps[META_PROP_VERTICAL], YGNodeStyleSetMargin, node, YGEdgeVertical);
   RCT_SET_YGVALUE_AUTO(metaProps[META_PROP_ALL], YGNodeStyleSetMargin, node, YGEdgeAll);
+//  RCT_SET_YGVALUE_AUTO(metaProps[META_PROP_BLOCK_START], YGNodeStyleSetMargin, node, YGEdgeTop);
 }
 
 static void RCTProcessMetaPropsBorder(const YGValue metaProps[META_PROP_COUNT], YGNodeRef node)
@@ -436,6 +443,7 @@ -(YGValue)margin##prop                            \
 RCT_MARGIN_PROPERTY(Bottom, BOTTOM)
 RCT_MARGIN_PROPERTY(Right, RIGHT)
 RCT_MARGIN_PROPERTY(Start, START)
+// RCT_MARGIN_PROPERTY(BlockStart, BLOCK_START)
 RCT_MARGIN_PROPERTY(End, END)
 
 // Padding

diff --git a/packages/rn-tester/js/components/RNTesterExampleFilter.js b/packages/rn-tester/js/components/RNTesterExampleFilter.js
@@ -185,6 +185,8 @@ const styles = StyleSheet.create({
     alignItems: 'center',
     position: 'relative',
     right: 10,
+    // backgroundColor: 'green',
+    // marginBlockStart: 100,
   },
   searchIcon: {
     width: 20,