-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add borderInlineColor implementation on iOS #31
base: main
Are you sure you want to change the base?
Conversation
|
df8ca74
to
714ed7a
Compare
fd1305d
to
efa5c90
Compare
6e4263f
to
918bbbf
Compare
@@ -281,12 +281,10 @@ export function SectionList_scrollable(Props: { | |||
ref={ref} | |||
ListHeaderComponent={HeaderComponent} | |||
ListFooterComponent={FooterComponent} | |||
// eslint-disable-next-line react/no-unstable-nested-components | |||
// $FlowFixMe[missing-local-annot] | |||
SectionSeparatorComponent={info => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ packages/rn-tester/js/examples/SectionList/SectionList-scrollable.js line 285 – Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “SectionList_scrollable” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true. (react/no-unstable-nested-components)
// $FlowFixMe[missing-local-annot] | ||
SectionSeparatorComponent={info => ( | ||
<CustomSeparatorComponent {...info} text="SECTION SEPARATOR" /> | ||
)} | ||
// eslint-disable-next-line react/no-unstable-nested-components | ||
// $FlowFixMe[missing-local-annot] | ||
ItemSeparatorComponent={info => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ packages/rn-tester/js/examples/SectionList/SectionList-scrollable.js line 289 – Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “SectionList_scrollable” and pass data as props. If you want to allow component creation in props, set allowAsProps option to true. (react/no-unstable-nested-components)
918bbbf
to
1484508
Compare
Summary
Changelog
Test Plan