Use prop-types; don't use React.createClass (React 15.5) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dupe of #38! |
JaapRood
reviewed
Apr 12, 2017
|
|
||
| DocumentTitle.prototype = Object.assign(Object.create(React.Component.prototype), { |
There was a problem hiding this comment.
I could be wrong, but Object.assign isn't supported in IE <= 11 according to MDN.
| @@ -34,6 +34,8 @@ | |||
| "react": "^0.13.0" | |||
| }, | |||
| "dependencies": { | |||
| "prop-types": "^15.5.0", | |||
| "react": "^15.5.0", | |||
There was a problem hiding this comment.
Pretty sure we wouldn't want to pull in our own copy of react here. Perhaps as a peer dependency?
|
Aye apologies for the dupe. You had mentioned "it's time to move on" so I assumed you had moved on ;) I'm happy to abandon in lieu of yours! Feel free to use anything I've done here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prop-typeslibrary to avoid React 15.5 deprecation warning.React.createClassAPI