Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making <AppContainer> take children #244

Closed
gaearon opened this issue Apr 18, 2016 · 1 comment
Closed

Consider making <AppContainer> take children #244

gaearon opened this issue Apr 18, 2016 · 1 comment

Comments

@gaearon
Copy link
Owner

gaearon commented Apr 18, 2016

Currently it looks like this:

<AppContainer
  component={Root}
  props={{ store }} /* depending on what you want to pass */
/>

As suggested by @halt-hammerzeit in reduxjs/redux-devtools@64f58b7#commitcomment-17142917 we might want to make it accept children instead:

<AppContainer>
  <Root store={store} />
</AppContainer>

I think I’m on board with this. A pull request is welcome!

@gaearon gaearon added this to the v3.0 milestone Apr 18, 2016
lolJS pushed a commit to lolJS/react-hot-loader that referenced this issue Apr 19, 2016
@alexisvincent
Copy link

@gaearon This can be closed now I think

@gaearon gaearon closed this as completed May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants