Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of proxied methods #797

Merged
merged 2 commits into from
Jan 16, 2018
Merged

Allow override of proxied methods #797

merged 2 commits into from
Jan 16, 2018

Conversation

theKashey
Copy link
Collaborator

  1. Make proxy-methods to be writable mobx-react no longer able to re-assign render method #796
  2. Set componentWillReceiveProps to call update-proxy before the render, which could be wrapped by third party v4.0.0 Beta not working with electron #794

@codecov-io
Copy link

codecov-io commented Jan 16, 2018

Codecov Report

Merging #797 into next will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #797      +/-   ##
==========================================
+ Coverage   81.66%   81.85%   +0.19%     
==========================================
  Files          23       23              
  Lines         518      518              
  Branches      102      143      +41     
==========================================
+ Hits          423      424       +1     
+ Misses         77       69       -8     
- Partials       18       25       +7
Impacted Files Coverage Δ
...ot-loader/src/internal/stack/hydrateLegacyStack.js 8.69% <0%> (ø) ⬆️
...ckages/react-hot-loader/src/internal/reactUtils.js 80.95% <0%> (ø) ⬆️
...-hot-loader/src/reconciler/hotReplacementRender.js 89.36% <0%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 624990c...5f3a848. Read the comment docs.

@theKashey theKashey merged commit c70f9a6 into next Jan 16, 2018
@gregberge gregberge deleted the render-override-case branch February 27, 2018 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants