Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #397 #398

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Fixes #397 #398

merged 2 commits into from
Nov 1, 2022

Conversation

raandree
Copy link
Contributor

@raandree raandree commented Oct 31, 2022

Pull Request

Pull Request (PR) description

When creating a module with ModuleType CompleteModule, RequiredModules.psd1 is incomplete

Fixed

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #398 (7d31b4a) into main (faa144b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #398   +/-   ##
===================================
  Coverage    81%    81%           
===================================
  Files        41     41           
  Lines      2225   2225           
===================================
  Hits       1807   1807           
  Misses      418    418           

@gaelcolas gaelcolas merged commit acd150e into gaelcolas:main Nov 1, 2022
@raandree raandree deleted the fix/397 branch November 4, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating a module with ModuleType CompleteModule, RequiredModules.psd1 is incomplete
2 participants