-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid flagging require-param
with @implements present (and possibly also @augments/@extends)
#100
Closed
Labels
Comments
Sounds like a reasonable request. PR welcome. |
brettz9
added a commit
to brettz9/eslint-plugin-jsdoc
that referenced
this issue
Nov 1, 2018
…and `allowAugmentsExtendsWithoutParam` and apply to `requireParam` (fixes gajus#100)
Closed
brettz9
added a commit
to brettz9/eslint-plugin-jsdoc
that referenced
this issue
Nov 13, 2018
…and `allowAugmentsExtendsWithoutParam` and apply to `requireParam` (fixes gajus#100)
brettz9
added a commit
to brettz9/eslint-plugin-jsdoc
that referenced
this issue
Dec 7, 2018
…and `allowAugmentsExtendsWithoutParam` and apply to `requireParam` (fixes gajus#100)
brettz9
added a commit
to brettz9/eslint-plugin-jsdoc
that referenced
this issue
Dec 7, 2018
…and `allowAugmentsExtendsWithoutParam` and apply to `requireParam` (fixes gajus#100)
🎉 This issue has been resolved in version 3.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 14, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For the
TransparentColor
function in this example:...eslint-plugin-jsdoc's
jsdoc/require-param
rule complains with:However, the JSDoc (for @implements) states:
This would seem to suggest that with
@implements
present, it is expected that values need only be added if they differ from the interface they are implementing.While JSDoc even states:
...it would be helpful if eslint-plugin-jsdoc could at least avoid the error when
@implements
is explicit on the block. In SVGEdit, we have a number of these real-world uses which are getting unduly flagged, and it would be a maintenance head-ache to have to duplicate parameter and return information on implementing objects as well as on the interface.(@augments (or its synonym
@extends
) should probably behave this way as well. I see you already support this optionally with @override.)Btw, I also filed an issue against jsdoctypeparser (at jsdoctypeparser/jsdoctypeparser#47 ) to allow "event:" within types as per the JSDoc spec--something I hope can be fixed so it can be surfaced through eslint-plugin-jsdoc (or make a fork if necessary if jsdoctypeparser is not being maintained).
And, FWIW, I've filed an issue at AtomLinter/linter-eslint#1192 for errors reported specifically for eslint-plugin/jsdoc rules--not sure if this is actually your issue or not.
The text was updated successfully, but these errors were encountered: