Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generate larger tables more quickly #224

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

m-allanson
Copy link
Contributor

@m-allanson m-allanson commented Feb 25, 2024

Testing locally, this change dropped the time taken for a large (3256 line) table from ~12 seconds to ~0.25 seconds.

Previously table was recreating the rowIndexMapping for each row. It looks like the mapping is the same each time, so I've moved the work up to happen only once, with the result stored in spanningCellManager.

Refs #223

@coveralls
Copy link

coveralls commented Mar 18, 2024

Pull Request Test Coverage Report for Build 8038857083

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 3374277795: 0.0%
Covered Lines: 642
Relevant Lines: 642

💛 - Coveralls

@nam-hle nam-hle merged commit 1a39e0c into gajus:master Mar 26, 2024
4 checks passed
Copy link

🎉 This PR is included in version 6.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants