Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wrapping with newlines #88

Merged
merged 3 commits into from
Jan 11, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions src/calculateCellHeight.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import _ from 'lodash';
import stringWidth from 'string-width';
import wrapWord from './wrapWord';
import wrapCell from './wrapCell';

/**
* @param {string} value
Expand All @@ -21,9 +20,5 @@ export default (value, columnWidth, useWrapWord = false) => {
throw new Error('Column width must be greater than 0.');
}

if (useWrapWord) {
return wrapWord(value, columnWidth).length;
}

return Math.ceil(stringWidth(value) / columnWidth);
return wrapCell(value, columnWidth, useWrapWord).length;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is length safe to use here?

Does it handle ansi?

I think not.

I think you need to use string-width.

Please add a test case with ansi characters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an array, so I would imagine .length is safe to use.

I will add the test case. What are you looking for, ANSI-wise?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good – misunderstood the change.

Thank you for adding the test case.

};
15 changes: 4 additions & 11 deletions src/mapDataUsingRowHeightIndex.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import _ from 'lodash';
import wrapString from './wrapString';
import wrapWord from './wrapWord';
import wrapCell from './wrapCell';

/**
* @param {Array} unmappedRows
Expand All @@ -21,16 +20,10 @@ export default (unmappedRows, rowHeightIndex, config) => {
// [{cell index within a virtual row; index1}]

cells.forEach((value, index1) => {
let chunkedValue;
const cellLines = wrapCell(value, config.columns[index1].width, config.columns[index1].wrapWord);

if (config.columns[index1].wrapWord) {
chunkedValue = wrapWord(value, config.columns[index1].width);
} else {
chunkedValue = wrapString(value, config.columns[index1].width);
}

chunkedValue.forEach((part, index2) => {
rowHeight[index2][index1] = part;
cellLines.forEach((cellLine, index2) => {
rowHeight[index2][index1] = cellLine;
});
});

Expand Down
35 changes: 35 additions & 0 deletions src/wrapCell.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import wrapString from './wrapString';
import wrapWord from './wrapWord';

/**
* Wrap a single cell value into a list of lines
*
* Always wraps on newlines, for the remainder uses either word or string wrapping
* depending on user configuration.
*
* @param {string} cellValue
* @param {number} columnWidth
* @param {boolean} useWrapWord
* @returns {Array}
*/
export default (cellValue, columnWidth, useWrapWord) => {
// First split on literal newlines
const cellLines = cellValue.split('\n');

// Then iterate over the list and word-wrap every remaining line if necessary.
for (let lineNr = 0; lineNr < cellLines.length;) {
let lineChunks;

if (useWrapWord) {
lineChunks = wrapWord(cellLines[lineNr], columnWidth);
} else {
lineChunks = wrapString(cellLines[lineNr], columnWidth);
}

// Replace our original array element with whatever the wrapping returned
cellLines.splice(lineNr, 1, ...lineChunks);
lineNr += lineChunks.length;
}

return cellLines;
};
6 changes: 6 additions & 0 deletions test/calculateCellHeight.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ describe('calculateCellHeight', () => {
}).to.throw(Error, 'Value must be a string.');
});
});
it('contains newlines', () => {
expect(calculateCellHeight('a\nb\nc', 10)).to.equal(3);
});
it('contains newlines and will be wrapped', () => {
expect(calculateCellHeight('aa\nbbb\nc', 2)).to.equal(4);
});
});
describe('context width', () => {
context('is not an integer', () => {
Expand Down
32 changes: 32 additions & 0 deletions test/mapDataUsingRowHeightIndex.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,38 @@ describe('mapDataUsingRowHeightIndex', () => {
});
});

context('single cell contains newlines', () => {
it('maps data to multiple rows', () => {
const config = {
columns: {
0: {
width: 100
}
}
};

const rowSpanIndex = [
5
];

const data = [
[
'aa\nbb\ncc\ndd\nee'
]
];

const mappedData = mapDataUsingRowHeightIndex(data, rowSpanIndex, config);

expect(mappedData).to.deep.equal([
['aa'],
['bb'],
['cc'],
['dd'],
['ee']
]);
});
});

context('multiple cells spans multiple rows', () => {
it('maps data to multiple rows', () => {
const config = {
Expand Down