Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return uuid when create a new keystore from LocalWallet #557

Closed
stephenctw opened this issue Nov 5, 2021 · 3 comments
Closed

Return uuid when create a new keystore from LocalWallet #557

stephenctw opened this issue Nov 5, 2021 · 3 comments

Comments

@stephenctw
Copy link

Currently the LocalWallet::new_keystore() doesn't return the uuid that's available from the inner eth_keystore::new call. Making it impossible to manage the keystore in the filesystem programmatically. Please also return the uuid from eth_keystore::new so the actual keystore file can be located easily.

@gakonst
Copy link
Owner

gakonst commented Nov 5, 2021

@roynalnaruto FYI

@roynalnaruto
Copy link
Collaborator

@stephenctw Thanks for having created the issue. I've made the necessary changes in the above linked PR 👍

@gakonst
Copy link
Owner

gakonst commented Nov 5, 2021

@stephenctw closing, please re-open if the PR doesn't address your problem!

@gakonst gakonst closed this as completed Nov 5, 2021
meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this issue Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants