fix(core): encode absent tx access_list correctly #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optional access list on `Transaction` was being incorrectly encoded as an empty string (0x80) when omitted, when it should be encoded as an empty list (0xc0). Fixes gakonst#1134.
michaelsproul
force-pushed
the
rlp-access-list-none
branch
from
2d1d2df
to
c51ed18
Compare
gakonst
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The optional access list on
Transactionwas being incorrectly encoded as an empty string (0x80) when omitted, when it should be encoded as an empty list (0xc0).Fixes #1134.
Solution
Add a new function
rlp_opt_listfor encoding optional RLP list structures. It encodes an empty list when its argument isNone. The new testrlp_london_no_access_listensures that the encoding of a transaction with aNoneaccess list matches the encoding of a transaction with an empty access list. The expected encoding is exactly the same as for therlp_londontest.The transaction request types are unaffected as they have non-optional access lists.
PR Checklist