Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feature: allow event builder to stream with meta #1483

Merged
merged 4 commits into from
Jul 17, 2022

Conversation

prestwich
Copy link
Collaborator

@prestwich prestwich commented Jul 17, 2022

Motivation

Event builder stream & subscribe always discards metadata. This sucks :)

Solution

Add a near-identical functions that retain metadata

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@prestwich prestwich added the enhancement New feature or request label Jul 17, 2022
@prestwich prestwich requested a review from gakonst July 17, 2022 05:29
@prestwich prestwich self-assigned this Jul 17, 2022
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

the return type is enormous lol

@gakonst gakonst merged commit 13ce18f into master Jul 17, 2022
@gakonst gakonst deleted the prestwich/stream-with-meta branch July 17, 2022 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants