feat: add support for Geth built-in tracer and config #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuTuGu
commented
Feb 7, 2023
| #[serde(default, deserialize_with = "from_int_or_hex")] | ||
| pub gas: U256, | ||
| #[serde(default, deserialize_with = "from_int_or_hex", rename = "gasUsed")] | ||
| pub gas_used: U256, |
There was a problem hiding this comment.
The gas and gas_used fields are not compatible with the legacy format. Should we change it to Option, and which might be a break change?
For now, to be compatible with previous versions, I've only added a default handling, which returns U256::zero() instead of None.
mattsse
requested changes
Feb 7, 2023
Comment on lines
+16
to
+17
| #[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)] | ||
| pub struct PreStateMode(pub BTreeMap<Address, AccountState>); |
There was a problem hiding this comment.
I think this should probably b #[serde(transparent)]?
There was a problem hiding this comment.
Seems transparent is enabled for newtype by default?
ethers-core/src/types/trace/geth/test_data/call_tracer/default.rs
Outdated
Show resolved
Hide resolved
gakonst
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now only
callTraceris supported, add morebuild-intracer and config support.Solution
Refs: #2064
PR Checklist