Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feat: detect ethers crate paths in derive macros #366

Merged
merged 2 commits into from
Aug 6, 2021
Merged

feat: detect ethers crate paths in derive macros #366

merged 2 commits into from
Aug 6, 2021

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 5, 2021

Motivation

  • The EthEvent and EthAbiType derive macros are usable with ethers_contract and ethers_core only, therefore it depends on ethers_core which requires use ethers::core as ethers_core; alias to compile.

Solution

  • parse the project's Cargo.toml and check the dependencies for ethers dependency, if the dependency is present then EthEvent relies on ethers::core.

@mattsse mattsse force-pushed the determine-ethers-crate-name branch from dd7fb51 to d5ea07c Compare August 5, 2021 23:35
@mattsse mattsse force-pushed the determine-ethers-crate-name branch from d5ea07c to 9137475 Compare August 5, 2021 23:38
gakonst
gakonst approved these changes Aug 6, 2021
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolute legend - thank you. LGTM.

@gakonst gakonst merged commit b0b4f4e into gakonst:master Aug 6, 2021
@gakonst gakonst mentioned this pull request Aug 28, 2021
Merged
meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this pull request Mar 21, 2022
@mds1
chore: fix comment (gakonst#366)
fd8ef3c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @gakonst