This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Add authorization for http and websocket #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
suggested changes
Jan 25, 2022
mattsse
suggested changes
Jan 26, 2022
|
Thanks for your feedback! |
mattsse
reviewed
Jan 26, 2022
|
Thanks a lot! |
mattsse
approved these changes
Jan 26, 2022
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds basic and bearer authentication for http and non-wasm websockets transport.
Motivation
Some people operate their node behind a reverse-proxy which uses some form of authentication. This pull request makes it possible to use ethers-rs in this case.
Solution
The solution is to inject auth headers into http requests and the websocket handshake request.
PR Checklist