Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slippage tolerance setting to add liquidity in omnipool #808

Closed
jak-pan opened this issue Apr 18, 2024 · 2 comments
Closed

Add slippage tolerance setting to add liquidity in omnipool #808

jak-pan opened this issue Apr 18, 2024 · 2 comments
Assignees

Comments

@jak-pan
Copy link
Contributor

jak-pan commented Apr 18, 2024

No description provided.

@mrq1911
Copy link
Member

mrq1911 commented May 15, 2024

dont change current function to keep backward compatibility, create new function with this param instead.

Alternatively adding param as a Option could achieve the same effect, but i am not sure that encoded call from previous version would be accepted. That needs to be tested, but ultimately it is not as big of deal as need to rewrite frontend integrations.

also remove liquidity should have slippage limit

@dmoka
Copy link
Contributor

dmoka commented Jun 19, 2024

Closed as fixed at #822

@dmoka dmoka closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants