Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add omnipool liquidity limits #822

Merged
merged 14 commits into from
Jun 7, 2024
Merged

Conversation

dmoka
Copy link
Contributor

@dmoka dmoka commented May 20, 2024

Solves this: #808

@dmoka dmoka self-assigned this May 20, 2024
Copy link

github-actions bot commented May 20, 2024

Crate versions that have been updated:

  • pallet-omnipool: v4.2.2 -> v4.3.0

Runtime version has not been increased.

pallets/omnipool/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid code duplication, i'd suggest to call the new version of add_ and remove_ liquidity from the original add_liquidity and remove_liquidity with min limits.

Copy link
Contributor

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one final change

pallets/omnipool/src/lib.rs Outdated Show resolved Hide resolved
pallets/omnipool/Cargo.toml Outdated Show resolved Hide resolved
@dmoka dmoka merged commit d14172d into master Jun 7, 2024
4 checks passed
@dmoka dmoka deleted the feat/add-omnipool-liquidty-limits branch June 7, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants