Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update weights for all pallets #164

Merged
merged 5 commits into from
Mar 18, 2021
Merged

Conversation

enthusiastmartin
Copy link
Contributor

Description

Weights update for all pallets

Related Issue

Motivation and Context

Recent substrate3 upgrade seems to improve performance in some areas.

How Has This Been Tested?

benchbot

Checklist:

  • I have updated the documentation if necessary.
  • I have added tests to cover my changes, regression test if fixing an issue.
  • This is a breaking change.

@enthusiastmartin
Copy link
Contributor Author

/bench runtime pallet amm

@hydra-bench-bot
Copy link

hydra-bench-bot bot commented Mar 18, 2021

Finished benchmark for branch: weights_update

Benchmark: Benchmark Runtime Pallet

/home/hydra/.cargo/bin/cargo run --release --features=runtime-benchmarks --manifest-path=node/Cargo.toml -- benchmark --chain=dev --steps=5 --repeat=20 --pallet=amm --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=weights.rs --template=.maintain/pallet-weight-template.hbs

Results

Pallet: "amm", Extrinsic: "create_pool", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 189.6
µs

Reads = 11
Writes = 13
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 189.6
µs

Reads = 11
Writes = 13
Pallet: "amm", Extrinsic: "add_liquidity", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 171.6
µs

Reads = 9
Writes = 8
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 171.6
µs

Reads = 9
Writes = 8
Pallet: "amm", Extrinsic: "remove_liquidity", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 170.8
µs

Reads = 8
Writes = 7
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 170.8
µs

Reads = 8
Writes = 7
Pallet: "amm", Extrinsic: "sell", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 122.1
µs

Reads = 5
Writes = 4
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 122.1
µs

Reads = 5
Writes = 4
Pallet: "amm", Extrinsic: "buy", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 121.2
µs

Reads = 5
Writes = 4
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 121.2
µs

Reads = 5
Writes = 4

@enthusiastmartin enthusiastmartin changed the title Weights update for transaction_multi_payment pallet Weights update for all pallets Mar 18, 2021
@enthusiastmartin
Copy link
Contributor Author

/bench runtime pallet exchange

@hydra-bench-bot
Copy link

hydra-bench-bot bot commented Mar 18, 2021

Finished benchmark for branch: weights_update

Benchmark: Benchmark Runtime Pallet

/home/hydra/.cargo/bin/cargo run --release --features=runtime-benchmarks --manifest-path=node/Cargo.toml -- benchmark --chain=dev --steps=5 --repeat=20 --pallet=exchange --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=weights.rs --template=.maintain/pallet-weight-template.hbs

Results

Pallet: "exchange", Extrinsic: "known_overhead_for_on_finalize", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 11.78
µs

Reads = 1
Writes = 0
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 11.78
µs

Reads = 1
Writes = 0
Pallet: "exchange", Extrinsic: "sell_intention", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 109.7
µs

Reads = 6
Writes = 2
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 109.7
µs

Reads = 6
Writes = 2
Pallet: "exchange", Extrinsic: "buy_intention", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 112.7
µs

Reads = 6
Writes = 2
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 112.7
µs

Reads = 6
Writes = 2
Pallet: "exchange", Extrinsic: "on_finalize", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 0
+ t 110.8
µs

Reads = 7 + (2 * t)
Writes = 4 + (2 * t)
Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
t mean µs sigma µs %
0 14.22 0.034 0.2%
200 21760 22.68 0.1%
400 43840 54.54 0.1%
600 66060 62.45 0.0%
800 88290 127.6 0.1%
1000 111000 135.9 0.1%

Quality and confidence:
param error
t 0.1

Model:
Time ~= 0
+ t 110.9
µs

Reads = 4 + (2 * t)
Writes = 2 + (2 * t)
Pallet: "exchange", Extrinsic: "on_finalize_buys_no_matches", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 5.432
+ t 125
µs

Reads = 7 + (2 * t)
Writes = 4 + (2 * t)
Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
t mean µs sigma µs %
0 14.14 0.106 0.7%
20 2504 2.89 0.1%
40 4974 7.004 0.1%
60 7511 14.9 0.1%
80 10010 18.02 0.1%
100 12530 23.24 0.1%

Quality and confidence:
param error
t 0.079

Model:
Time ~= 0
+ t 125.2
µs

Reads = 4 + (2 * t)
Writes = 2 + (2 * t)
Pallet: "exchange", Extrinsic: "on_finalize_sells_no_matches", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 14.14
+ t 109.3
µs

Reads = 7 + (2 * t)
Writes = 4 + (2 * t)
Min Squares Analysis

-- Extrinsic Time --

Data points distribution:
t mean µs sigma µs %
0 14.24 0.085 0.5%
20 2216 12.06 0.5%
40 4373 11.4 0.2%
60 6547 13.75 0.2%
80 8754 12.79 0.1%
100 10970 12.32 0.1%

Quality and confidence:
param error
t 0.084

Model:
Time ~= 8.528
+ t 109.4
µs

Reads = 4 + (2 * t)
Writes = 2 + (2 * t)
Pallet: "exchange", Extrinsic: "sell_extrinsic", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 121.3
µs

Reads = 5
Writes = 4
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 121.3
µs

Reads = 5
Writes = 4
Pallet: "exchange", Extrinsic: "on_finalize_for_one_sell_extrinsic", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 163.8
µs

Reads = 9
Writes = 6
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 163.8
µs

Reads = 9
Writes = 6
Pallet: "exchange", Extrinsic: "buy_extrinsic", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 120.9
µs

Reads = 5
Writes = 4
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 120.9
µs

Reads = 5
Writes = 4
Pallet: "exchange", Extrinsic: "on_finalize_for_one_buy_extrinsic", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 179.5
µs

Reads = 9
Writes = 6
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 179.5
µs

Reads = 9
Writes = 6

@enthusiastmartin enthusiastmartin changed the title Weights update for all pallets fix: update weights for all pallets Mar 18, 2021
@enthusiastmartin
Copy link
Contributor Author

/bench runtime pallet transaction_multi_payment

@hydra-bench-bot
Copy link

hydra-bench-bot bot commented Mar 18, 2021

Finished benchmark for branch: weights_update

Benchmark: Benchmark Runtime Pallet

/home/hydra/.cargo/bin/cargo run --release --features=runtime-benchmarks --manifest-path=node/Cargo.toml -- benchmark --chain=dev --steps=5 --repeat=20 --pallet=transaction_multi_payment --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=weights.rs --template=.maintain/pallet-weight-template.hbs

Results

Pallet: "transaction_multi_payment", Extrinsic: "swap_currency", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 132.9
µs

Reads = 6
Writes = 4
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 132.9
µs

Reads = 6
Writes = 4
Pallet: "transaction_multi_payment", Extrinsic: "set_currency", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 34.62
µs

Reads = 2
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 34.62
µs

Reads = 2
Writes = 1
Pallet: "transaction_multi_payment", Extrinsic: "add_currency", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 26.29
µs

Reads = 2
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 26.29
µs

Reads = 2
Writes = 1
Pallet: "transaction_multi_payment", Extrinsic: "remove_currency", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 26.23
µs

Reads = 2
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 26.23
µs

Reads = 2
Writes = 1
Pallet: "transaction_multi_payment", Extrinsic: "add_member", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 23.02
µs

Reads = 1
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 23.02
µs

Reads = 1
Writes = 1
Pallet: "transaction_multi_payment", Extrinsic: "remove_member", Lowest values: [], Highest values: [], Steps: [5], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 24.96
µs

Reads = 1
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 24.96
µs

Reads = 1
Writes = 1

@enthusiastmartin enthusiastmartin merged commit dc1ac04 into master Mar 18, 2021
@mrq1911 mrq1911 deleted the weights_update branch April 6, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants