feat: enable polkadotXcm.send #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have been updated:
Runtime version has been increased. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 65.01% 65.01%
=======================================
Files 137 137
Lines 9898 9899 +1
=======================================
+ Hits 6435 6436 +1
Misses 3463 3463
☔ View full report in Codecov by Sentry. |
mrq1911
reviewed
Jul 29, 2023
runtime/hydradx/src/xcm.rs
Outdated
| @@ -413,6 +413,7 @@ impl Contains<RuntimeCall> for SafeCallFilter { | |||
| | RuntimeCall::Currencies(..) | |||
| | RuntimeCall::Tokens(..) | |||
| | RuntimeCall::OrmlXcm(..) | |||
| | RuntimeCall::PolkadotXcm(pallet_xcm::Call::send { .. },) | |||
There was a problem hiding this comment.
@green-jay i don't think we can unfilter it here, is shouldn't be necessary anyway
cc @Roznovjak
There was a problem hiding this comment.
btw. seems weird that OrmlXcm is unfiltered as well
mrq1911
changed the title
mrq1911
reviewed
Jul 30, 2023
mrq1911
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow polkadotXcm.send to be called locally as an extrinsic and remotely within a XCM Transact call