Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use genesis builder #835

Merged
merged 2 commits into from
Jun 7, 2024
Merged

refactor: use genesis builder #835

merged 2 commits into from
Jun 7, 2024

Conversation

Roznovjak
Copy link
Contributor

@Roznovjak Roznovjak commented Jun 6, 2024 •
edited
Loading

Fixes: #813. This PR removes deprecated method from_genesis and replaces it with builder.

@Roznovjak Roznovjak self-assigned this Jun 6, 2024
@Roznovjak Roznovjak changed the base branch from master to polkadot-v1.7.2 June 6, 2024 12:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

Crate versions that have been updated:

  • hydradx: v13.0.0 -> v13.1.0
  • hydradx-runtime: v242.0.0 -> v243.0.0

Runtime version has been increased.

@Roznovjak Roznovjak linked an issue Jun 6, 2024 that may be closed by this pull request
refactor: chainspec from_genesis is deprecated, use chainspec builder #813
Open
@Roznovjak Roznovjak changed the title refactor: use genesis builder builder refactor: use genesis builder Jun 6, 2024
dmoka
dmoka approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@dmoka dmoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 comment, nothing critical.

node/Cargo.toml Outdated Show resolved Hide resolved
node/src/chain_spec/mod.rs Show resolved Hide resolved
@Roznovjak Roznovjak merged commit 3a89a21 into polkadot-v1.7.2 Jun 7, 2024
4 checks passed
@Roznovjak Roznovjak deleted the chainspec_builder branch June 7, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmoka dmoka dmoka approved these changes

@martinfridrich martinfridrich Awaiting requested review from martinfridrich

@mrq1911 mrq1911 Awaiting requested review from mrq1911

@jak-pan jak-pan Awaiting requested review from jak-pan

@enthusiastmartin enthusiastmartin Awaiting requested review from enthusiastmartin

Assignees

@Roznovjak Roznovjak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: chainspec from_genesis is deprecated, use chainspec builder
2 participants
@Roznovjak @dmoka