Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Claims pallet #98

Merged
merged 43 commits into from
Mar 7, 2021
Merged

Claims pallet #98

merged 43 commits into from
Mar 7, 2021

Conversation

green-jay
Copy link
Contributor

No description provided.

enthusiastmartin
enthusiastmartin reviewed Feb 9, 2021
View reviewed changes
pallets/claims/src/lib.rs Outdated Show resolved Hide resolved
pallets/claims/src/lib.rs Outdated Show resolved Hide resolved
pallets/claims/src/lib.rs Outdated Show resolved Hide resolved
pallets/claims/src/lib.rs Outdated Show resolved Hide resolved
enthusiastmartin
enthusiastmartin requested changes Feb 11, 2021
View reviewed changes
pallets/claims/src/tests.rs Outdated Show resolved Hide resolved
@green-jay green-jay changed the title Claims - Initial commit Claims pallet Feb 11, 2021
jak-pan
jak-pan reviewed Feb 15, 2021
View reviewed changes
pallets/claims/src/lib.rs Outdated Show resolved Hide resolved
jak-pan
jak-pan reviewed Feb 16, 2021
View reviewed changes
runtime/src/lib.rs Outdated Show resolved Hide resolved
jak-pan
jak-pan reviewed Mar 2, 2021
View reviewed changes
node/src/chain_spec.rs Outdated Show resolved Hide resolved
jak-pan
jak-pan reviewed Mar 2, 2021
View reviewed changes
pallets/claims/src/lib.rs Outdated Show resolved Hide resolved
jak-pan
jak-pan requested changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@jak-pan jak-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks very nice just some tidying up and maybe a few more migration tests and we're good

@enthusiastmartin enthusiastmartin mentioned this pull request Mar 2, 2021
Closed
@green-jay green-jay marked this pull request as ready for review March 3, 2021 11:14
mrq1911
mrq1911 reviewed Mar 7, 2021
View reviewed changes
pallets/claims/src/lib.rs Outdated Show resolved Hide resolved
@mrq1911 mrq1911 mentioned this pull request Mar 7, 2021
Merged
@mrq1911
Merge pull request #132 from galacticcouncil/claims_pallet_version
99fdd12 
fix: claims migration based on pallet version
jak-pan
jak-pan approved these changes Mar 7, 2021
View reviewed changes
Copy link
Contributor

@jak-pan jak-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested. Let's go 🤘

@jak-pan jak-pan merged commit d0e89c2 into master Mar 7, 2021
This was referenced Mar 7, 2021
Closed
Closed
@jak-pan jak-pan deleted the feature/claims branch March 14, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roznovjak Roznovjak Roznovjak left review comments

@mrq1911 mrq1911 mrq1911 approved these changes

@jak-pan jak-pan jak-pan approved these changes

@enthusiastmartin enthusiastmartin Awaiting requested review from enthusiastmartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@green-jay @mrq1911 @jak-pan @enthusiastmartin @Roznovjak @pmensik