Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid further processing when the XML file is not related to a tool wrapper file #74

Closed
davelopez opened this issue Dec 16, 2020 · 0 comments · Fixed by #75
Closed

Avoid further processing when the XML file is not related to a tool wrapper file #74

davelopez opened this issue Dec 16, 2020 · 0 comments · Fixed by #75
Assignees
Labels
bug Something isn't working language server Related to the language server paper-cut A trivially fixable usability bug vscode extension Related to the VS Code extension

Comments

@davelopez
Copy link
Collaborator

The language server extension gets activated by default when the user opens a file with .xml extension. It seems there is currently no way to activate the extension based on the contents (for example to differentiate a tool wrapper from some other random XML file).
One possible solution to this issue is to 'peek' the contents of the XML file and determine if this is actually a tool wrapper related file (tool, macros, etc.). If the XML file does not pass this check, all the language server requests will be discarded. The extension will still be active, but this will help avoid any further processing or errors trying to process a file that it's not meant to be analyzed.

@davelopez davelopez added bug Something isn't working language server Related to the language server vscode extension Related to the VS Code extension paper-cut A trivially fixable usability bug labels Dec 16, 2020
@davelopez davelopez self-assigned this Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working language server Related to the language server paper-cut A trivially fixable usability bug vscode extension Related to the VS Code extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant