Avoid processing unknown XML documents #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing directly the Document to the services, the parsed XmlDocument is passed now.
davelopez
added
bug
Now the full parsing is done only if the document is supported
bgruening
reviewed
Dec 17, 2020
| @@ -8,3 +8,4 @@ pytest-mock | |||
| flake8 | |||
| flake8-bugbear | |||
| black | |||
| lxml-stubs | |||
There was a problem hiding this comment.
This is not really needed, but it is really useful in development for getting linting and auto-completion in the IDE with lxml. They are just external type annotations since the lxml is mostly compiled code and can not be directly used by the static type linter. I found it here
There was a problem hiding this comment.
Oh, this is nifty thanks for sharing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR detects the type of XML document when a request is received by the server and, if the XML is not one of the supported types (
toolandmacrosat the moment), further processing of the request is ignored. This fixes some false positives when you are working with different kinds of XML documents and the Galaxy Language Server is installed since the server will not try to validate (or use any other galaxy tool-related feature) those files.Some refactoring was needed to simplify and unify the way XML documents are processed by some of the services. Also, additional tests were added.
This fixes #74