Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.1] Persist uploaded data between Regular and Collection upload tabs #19083

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Oct 30, 2024

Uses a singular DefaultBox component so that both the Regular and Collection tabs in the UploadContainer (modal) have the same files.

Fixes #19081

use_singular_default_box_in_upload.mp4

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Uses a singular `DefaultBox` component so that both the Regular and Collection tabs in the `UploadContainer` (modal) have the same files.

Fixes galaxyproject#19081
@github-actions github-actions bot added this to the 24.1 milestone Oct 30, 2024
@ahmedhamidawan ahmedhamidawan linked an issue Oct 30, 2024 that may be closed by this pull request
@ahmedhamidawan
Copy link
Member Author

ahmedhamidawan commented Oct 30, 2024

We can target dev instead if that's better?

👀 Looking at failing seleniums like selenium.common.exceptions.TimeoutException: Message: Timeout waiting on CSS selector [div#regular button#btn-local] to become clickable. btw, they might be related...

@mvdbeek
Copy link
Member

mvdbeek commented Nov 7, 2024

That's neat, thank you!

@mvdbeek
Copy link
Member

mvdbeek commented Nov 7, 2024

The selenium test failures look maybe related ?

@mvdbeek mvdbeek merged commit 2c59753 into galaxyproject:release_24.1 Nov 8, 2024
48 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload does not keep pasted data when switching tabs
2 participants