Removes the option to zip or not the binary serialisation format #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies lots of serialisation function.
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
|
Now it's the record experiments that are broken, when I try to step back nothing happens and I have this message: |
The two functions are now being used only in one place, offering the possibility to turn it off or on much more easily.
|
The issue(s) should now be completely fixed. |
|
I still noticed a problem, when trying to restore agents from a file in the All other serialisation models work properly |
|
Make sure you clean your directory before. Agents / Simulations files are not overwritten, so you may have old ones in your directory |
|
Yes I tried to remove previous saved agents and even create a new workspace but I still have this problem |
|
I couldn't reproduce the problem you described on macOS. So i tried the model in a Windows installation and I do not have any problem... Restoring and recreating agents from disk work w/o problems. |
|
I tried on two other computers and can reproduce it. I forgot to add this part of the exception: Also it seems to at least partially work so maybe the error stack is written in the console of eclipse but the error is handled by gama and another mechanism is called to finish the work ? |
|
I followed the execution step by step and it is indeed just an "expected" error message found in the console, and the execution continues to something else, there is no actual bug. It is caused by the public static void restoreFromString(final IAgent agent, final String string) {
try {
restoreFromBytes(agent, string.getBytes(STRING_BYTE_ARRAY_CHARSET));
} catch (Throwable e) {
try {
restoreFromFile(agent, string);
} catch (Throwable ex) {
GAMA.reportAndThrowIfNeeded(agent.getScope(), GamaRuntimeException.create(ex, agent.getScope()), true);
}
}
}Even though it is not clear from that code, when public Object asObject(final byte b[]) {
try {
final byte[] input = ByteArrayZipper.unzip(b);
return getObjectInput(input).readObject();
} catch (Exception e) {
System.out.println("unable to decode:" + new String(b, 0, 0, Math.min(b.length, 100)));
FSTUtil.<RuntimeException> rethrow(e);
}
return null;
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies lots of serialisation function. Fixes #351