Miscellaneous fixes for headless legacy #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now I'm just handling the case where the dataType variable is not defined. But if we run headless legacy on Model 12.gaml from model library, we define the displays as 2d explicitly, so shouldn't dataType be 2d display ? And if so, what is the expected dataType in case of 3d display ?
|
I have no idea. I have never really looked into this part of the code ... |
…output directories cannot be created
|
I dug a bit and this part of the code is basically only called in legacy mode (and maybe some check mode) so as long as the initial bug is fixed and there's no new weird behaviour in legacy I think it's safe to merge. While digging I found a few other issues that I patched in the following commits, the most important was restoring the |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -121,6 +121,9 @@ private static Injector configureInjector() { | |||
| /** The Constant THREAD_PARAMETER. */ | |||
| final public static String THREAD_PARAMETER = "-hpc"; | |||
|
|
|||
| /** The Constant THREAD_PARAMETER. */ | |||
There was a problem hiding this comment.
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.79 to 5.00, threshold = 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting by fixing #352: the problem happened when reaching the exportVariable function and trying to serialize the displays.
For now I'm just handling the case where the dataType variable is not defined.
But the issue appeared on
Model 12.gamlfrom the library of models, in which the displays are explicitly defined as 2d, so shouldn't dataType be DataType.DISPLAY2D when entering this function? And if so, what is the expected dataType in case of 3d display ?@AlexisDrogoul any pointer ?