Update FileUtils.java #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we do not raise an error when no file is found using the workspace
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
+160
to
+167
| for (final String folder : a.getWorkingPaths()) { | ||
| IContainer[] containers = ROOT.findContainersForLocation(new Path(folder)); | ||
| for (IContainer container : containers) { | ||
| final String file = findInWorkspace(fp, container, mustExist); | ||
| if (file != null) { | ||
| DEBUG.OUT("Hit with workspace-based search: " + file); | ||
| return file; | ||
| } |
There was a problem hiding this comment.
❌ Getting worse: Complex Method
constructAbsoluteFilePath increases in cyclomatic complexity from 11 to 12, threshold = 9
| @@ -9,8 +9,6 @@ | |||
| ********************************************************************************************************/ | |||
| package gama.core.common.util; | |||
|
|
|||
| import static java.util.stream.Collectors.toList; | |||
There was a problem hiding this comment.
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 4.93 to 4.96, threshold = 4
Comment on lines
+160
to
+167
| for (final String folder : a.getWorkingPaths()) { | ||
| IContainer[] containers = ROOT.findContainersForLocation(new Path(folder)); | ||
| for (IContainer container : containers) { | ||
| final String file = findInWorkspace(fp, container, mustExist); | ||
| if (file != null) { | ||
| DEBUG.OUT("Hit with workspace-based search: " + file); | ||
| return file; | ||
| } |
There was a problem hiding this comment.
ℹ Getting worse: Deep, Nested Complexity
constructAbsoluteFilePath increases in nested complexity depth from 4 to 5, threshold = 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we do not raise an error when no file is found using the workspace. Fixes #318