Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix menu item highlighting #130

Closed
webbertakken opened this issue Mar 4, 2021 · 3 comments
Closed

Fix menu item highlighting #130

webbertakken opened this issue Mar 4, 2021 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/

Comments

@webbertakken
Copy link
Member

Menu should be highlighting the page that's currently open.

I probably made a mismatch in keys in MenuSidebar.
@webbertakken webbertakken added the bug Something isn't working label Mar 4, 2021
@webbertakken webbertakken mentioned this issue Mar 4, 2021
Merged
3 tasks
@webbertakken webbertakken added good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/ labels Oct 1, 2021
@julhad
Copy link
Contributor

julhad commented Oct 6, 2021

Does this issue address the highlighting for the old (v1) docs (e.g. https://game.ci/docs/github/v1/builder)? Because opening the current docs (e.g. https://game.ci/docs/gitlab/example-project) highlights the correct menu on the left for me (Safari 15.0).

@webbertakken
Copy link
Member Author

If I open https://game.ci/docs/gitlab/deployment/android#bundle-version-code it's not highlighting the menu item correctly.

@webbertakken webbertakken mentioned this issue Apr 24, 2022
Merged
18 tasks
@webbertakken
Copy link
Member Author

Obsoleted by #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webbertakken @julhad