-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace documentation website with Docusaurus #259
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Tried deployment using offending urls so far:
The |
I just tested that locally, I modified Details about what I triedyarn
echo " " >> src/pages/docs/docker/versions.tsx
git add src/pages/docs/docker/versions.tsx
git commit -m "test" On a side note, it took more time than what I expected. I think it can be improved later tho. I think it's better to have this than it is to skip it even if it takes some time. Observations concerning eslint execution timeI tried it again and still getting similar result:
Maybe it's just # similar to how it's invoked by lefthook
time ./node_modules/.bin/eslint '*/**/*.{js,ts,tsx}' --quiet --fix src/pages/docs/docker/versions.tsx
./node_modules/.bin/eslint '*/**/*.{js,ts,tsx}' --quiet --fix 17.17s user 1.48s system 157% cpu 11.832 total # tried without '*/**/*.{js,ts,tsx}', seems to be a bit better
time ./node_modules/.bin/eslint --quiet --fix src/pages/docs/docker/versions.tsx
./node_modules/.bin/eslint --quiet --fix src/pages/docs/docker/versions.tsx 12.93s user 1.34s system 148% cpu 9.618 total |
This was only useful when tailwindcss base css was loaded, this is not the case anymore
I did a quick pass on each of the pages and everything seems fine. The only thing I found that I felt it was worth fixing is that the Left side: docusaurus, right side, previous implementation. My main complain about it is that most of the yaml keys aren't colored. I might be picky tho, but I use dracula theme every day in my IDE and my yaml files looks much better than the one from I went ahead with 57294e6 Before: After: The dark theme is also much closer to the |
lgtm 🚀 |
@GabLeRoux thanks for pointing that out. Fixing in #272
@GabLeRoux thanks for pointing that out. Fixing in #272 |
While working on replacing on #218 I found that there is a docsearch
Docusaurus v2 template
available and felt it would be interesting to give this optimized site generator a try.Changes
introduction
sidebar item at top of the list and have it link to desired platform (github or gitlab)see Replace documentation website with Docusaurus #259 (comment)
FixSee Docusaurus versions page as docs page #266, for now I suggest we keep the warning until we get rid of AntD and move to an actualDuplicate routes found!
warning:mdx
docs page with a component that fits docs styling 👍This is due to a workaround to get the
versions
page to show in the navigation, but the page itself is handled by a docusaurus page.For this deployment to work, vercel settings needs to be updated to
docusaurus 2
:Concerning NodeJS version, it doesn't need to be updated as it can be determined from
package.json
's value 👍. Docusaurus is not compatible with Node 12, but it is compatible with Node 14 and 16. Vercel is not compatible with Node 16 so we're sticking with Node 14 for now.Checklist