Workaround for location tracker ending too early #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes some things for the dungeon tracker, and improves some related code
|
Good job on the fix! I wonder if it's possible to do the same for the entrance tracker too, because I tried generating a max settings rando and the entrance list was broken:
Here's the seed: |
|
Above is fixed by #627. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts the item locations and string data in a separate array of patches.
To increase the amount of writable locations, only
SPOILER_LOCDATSneeds to be increased. I tested making it over two thousand locations, which works:2023-01-06.20-38-33.mp4
Closes #609.
Also fixes some things for the dungeon tracker, and improves some related code.