Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Hyper Bosses" Option #646

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

Kewlan
Copy link
Collaborator

@Kewlan Kewlan commented Feb 14, 2023

Makes all bosses, including Ganon, act twice as fast!

@Kewlan
Copy link
Collaborator Author

Kewlan commented Feb 22, 2023

I'm putting this on hold because I want to test doing this by adding a patch in Actor_UpdateAll instead. Would make it shorter and more efficient, and easy to add for other actors like mini bosses if desired.

@Kewlan Kewlan marked this pull request as draft February 22, 2023 20:45
@Kewlan
Copy link
Collaborator Author

Kewlan commented Feb 26, 2023

I tried the other attempt by re-running the do { ... } while (i < 0xC) part of Actor_UpdateAll for bosses and enemies, but it had issues. See code and described issues in commit message here: main...Kewlan:OoT3D_Randomizer:hyper-bosses-2

This PR's version I've played two 100% seeds already and have noticed no issues. So while it does have a bunch of extra, repeated code, at least it works.

@Kewlan Kewlan marked this pull request as ready for review February 26, 2023 16:23
@HylianFreddy
Copy link
Collaborator

HylianFreddy commented Feb 27, 2023

I tried the other attempt by re-running the do { ... } while (i < 0xC) part of Actor_UpdateAll for bosses and enemies, but it had issues. See code and described issues in commit message here: main...Kewlan:OoT3D_Randomizer:hyper-bosses-2

This PR's version I've played two 100% seeds already and have noticed no issues. So while it does have a bunch of extra, repeated code, at least it works.

I made an attempt at implementing this feature using only a single patch, on the call to the actual update function inside Actor_UpdateAll. It seems to work decently, but I haven't added any of the "special cases to update in order" that are in this PR.
If you want to check it out here's my branch: https://github.com/HylianFreddy/OoT3D_Randomizer/tree/hyper-bosses-2 [Branch deleted, the commit is here]

@Kewlan
Copy link
Collaborator Author

Kewlan commented Feb 28, 2023

I made an attempt at implementing this feature using only a single patch, on the call to the actual update function inside Actor_UpdateAll. It seems to work decently, but I haven't added any of the "special cases to update in order" that are in this PR. If you want to check it out here's my branch: https://github.com/HylianFreddy/OoT3D_Randomizer/tree/hyper-bosses-2

Bongo Bongo and Barinade doesn't work properly like this because their actors need to be updated in normal order.

I'm motivated to keep trying now, so I'll mark as draft again.

@Kewlan
Copy link
Collaborator Author

Kewlan commented Feb 28, 2023

I tried methods that wouldn't require these special cases, but with no success. To use a patch instead is still a great idea though, so I went with that. I haven't added a hyper enemies option here because that will require a lot of testing for other special cases.

@Kewlan Kewlan marked this pull request as ready for review February 28, 2023 16:05
Makes all bosses, including Ganon, act twice as fast!
@gymnast86 gymnast86 merged commit b13a615 into gamestabled:main Mar 10, 2023
@Kewlan Kewlan deleted the hyper-bosses branch March 11, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants