This repository has been archived by the owner on Jun 16, 2020. It is now read-only.
Allow dark mode for modals #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now in GTSheet the indicator bar is set to a black background color with partial transparency. This switches it over to use system colors which will use a similar looking gray for light mode and a much lighter gray for dark mode. I needed this to support dark mode in my app, but another approach could be to allow a custom color for the notch to be passed the same way tint color is now. Either way, I figured I'd put in a PR for this.
This is what they look like now in light and then dark mode:
Also fixes an issue with the README that was brought up in issue #23