remove management workspace (opensearch-project#278)

* remove management workspace

* delete unnecessary code comments

* delete comments

src/core/public/index.ts

@@ -357,7 +357,6 @@ export { WorkspacesStart, WorkspacesSetup, WorkspacesService } from './workspace
 export {
   WorkspacePermissionMode,
   PUBLIC_WORKSPACE_ID,
-  MANAGEMENT_WORKSPACE_ID,
   WORKSPACE_TYPE,
   cleanWorkspaceId,
 } from '../utils';

src/core/public/utils/index.ts

@@ -38,5 +38,4 @@ export {
   formatUrlWithWorkspaceId,
   getWorkspaceIdFromUrl,
   PUBLIC_WORKSPACE_ID,
-  MANAGEMENT_WORKSPACE_ID,
 } from '../../utils';

src/core/server/index.ts

@@ -364,7 +364,6 @@ export {
   DEFAULT_APP_CATEGORIES,
   WorkspacePermissionMode,
   PUBLIC_WORKSPACE_ID,
-  MANAGEMENT_WORKSPACE_ID,
   WORKSPACE_TYPE,
 } from '../utils';
 

src/core/utils/constants.ts

@@ -15,5 +15,3 @@ export enum WorkspacePermissionMode {
 }
 
 export const PUBLIC_WORKSPACE_ID = 'public';
-
-export const MANAGEMENT_WORKSPACE_ID = 'management';

src/core/utils/index.ts

@@ -41,7 +41,6 @@ export {
   WORKSPACE_PATH_PREFIX,
   WorkspacePermissionMode,
   PUBLIC_WORKSPACE_ID,
-  MANAGEMENT_WORKSPACE_ID,
   WORKSPACE_TYPE,
 } from './constants';
 export { getWorkspaceIdFromUrl, formatUrlWithWorkspaceId, cleanWorkspaceId } from './workspace';

src/plugins/workspace/public/components/workspace_creator/workspace_form.tsx

@@ -34,7 +34,6 @@ import {
   AppNavLinkStatus,
   ApplicationStart,
   DEFAULT_APP_CATEGORIES,
-  MANAGEMENT_WORKSPACE_ID,
 } from '../../../../../core/public';
 import { useApplications } from '../../hooks';
 import { DEFAULT_CHECKED_FEATURES_IDS } from '../../../common/constants';
@@ -172,17 +171,8 @@ export const WorkspaceForm = ({
   const [color, setColor] = useState(defaultValues?.color);
   const [icon, setIcon] = useState(defaultValues?.icon);
   const [defaultVISTheme, setDefaultVISTheme] = useState(defaultValues?.defaultVISTheme);
-  const isEditingManagementWorkspace = defaultValues?.id === MANAGEMENT_WORKSPACE_ID;
-
-  // feature visibility section will be hidden in management workspace
-  // permission section will be hidden when permission is not enabled
-  const [selectedTab, setSelectedTab] = useState(
-    !isEditingManagementWorkspace
-      ? WorkspaceFormTabs.FeatureVisibility
-      : permissionEnabled
-      ? WorkspaceFormTabs.UsersAndPermissions
-      : WorkspaceFormTabs.NotSelected
-  );
+
+  const [selectedTab, setSelectedTab] = useState(WorkspaceFormTabs.FeatureVisibility);
   const [numberOfErrors, setNumberOfErrors] = useState(0);
   // The matched feature id list based on original feature config,
   // the feature category will be expanded to list of feature ids
@@ -602,14 +592,12 @@ export const WorkspaceForm = ({
       <EuiSpacer />
 
       <EuiTabs>
-        {!isEditingManagementWorkspace && (
-          <EuiTab
-            onClick={handleTabFeatureClick}
-            isSelected={selectedTab === WorkspaceFormTabs.FeatureVisibility}
-          >
-            <EuiText>{featureVisibilityTitle}</EuiText>
-          </EuiTab>
-        )}
+        <EuiTab
+          onClick={handleTabFeatureClick}
+          isSelected={selectedTab === WorkspaceFormTabs.FeatureVisibility}
+        >
+          <EuiText>{featureVisibilityTitle}</EuiText>
+        </EuiTab>
         {permissionEnabled && (
           <EuiTab
             onClick={handleTabPermissionClick}

src/plugins/workspace/public/components/workspace_menu/workspace_menu.tsx

@@ -20,7 +20,6 @@ import type { EuiContextMenuPanelItemDescriptor } from '@elastic/eui';
 import {
   ApplicationStart,
   HttpSetup,
-  MANAGEMENT_WORKSPACE_ID,
   WorkspaceAttribute,
   WorkspacesStart,
 } from '../../../../../core/public';
@@ -46,10 +45,7 @@ function getFilteredWorkspaceList(
   // list top5 workspaces except management workspace, place current workspace at the top
   return [
     ...(currentWorkspace ? [currentWorkspace] : []),
-    ...workspaceList.filter(
-      (workspace) =>
-        workspace.id !== MANAGEMENT_WORKSPACE_ID && workspace.id !== currentWorkspace?.id
-    ),
+    ...workspaceList.filter((workspace) => workspace.id !== currentWorkspace?.id),
   ].slice(0, 5);
 }
 
@@ -64,12 +60,7 @@ export const WorkspaceMenu = ({ basePath, getUrlForApp, workspaces, navigateToUr
       defaultMessage: 'OpenSearch Dashboards',
     }
   );
-  const managementWorkspaceName = i18n.translate(
-    'core.ui.primaryNav.workspacePickerMenu.managementWorkspaceName',
-    {
-      defaultMessage: 'Management',
-    }
-  );
+
   const filteredWorkspaceList = getFilteredWorkspaceList(workspaceList, currentWorkspace);
   const currentWorkspaceName = currentWorkspace?.name ?? defaultHeaderName;
 
@@ -199,17 +190,6 @@ export const WorkspaceMenu = ({ basePath, getUrlForApp, workspaces, navigateToUr
           icon: 'folderClosed',
           panel: 1,
         },
-        {
-          name: managementWorkspaceName,
-          icon: 'managementApp',
-          href: formatUrlWithWorkspaceId(
-            getUrlForApp(WORKSPACE_OVERVIEW_APP_ID, {
-              absolute: false,
-            }),
-            MANAGEMENT_WORKSPACE_ID,
-            basePath
-          ),
-        },
       ],
     },
     {

src/plugins/workspace/server/integration_tests/routes.test.ts

@@ -232,8 +232,8 @@ describe('workspace service', () => {
           page: 1,
         })
         .expect(200);
-      // Global and Management workspace will be created by default after workspace list API called.
-      expect(listResult.body.result.total).toEqual(4);
+      // Global workspace will be created by default after workspace list API called.
+      expect(listResult.body.result.total).toEqual(3);
     });
     it('unable to perform operations on workspace by calling saved objects APIs', async () => {
       const result = await osdTestServer.request
@@ -295,8 +295,8 @@ describe('workspace service', () => {
         })
         .expect(200);
       expect(findResult.body.total).toEqual(0);
-      // Global and Management workspace will be created by default after workspace list API called.
-      expect(listResult.body.result.total).toEqual(3);
+      // Global workspace will be created by default after workspace list API called.
+      expect(listResult.body.result.total).toEqual(2);
     });
   });
 });

src/plugins/workspace/server/workspace_client.ts

@@ -16,7 +16,6 @@ import type {
 import {
   ACL,
   DEFAULT_APP_CATEGORIES,
-  MANAGEMENT_WORKSPACE_ID,
   PUBLIC_WORKSPACE_ID,
   WORKSPACE_TYPE,
   WorkspacePermissionMode,
@@ -223,35 +222,6 @@ export class WorkspaceClientWithSavedObject implements IWorkspaceClientImpl {
       publicWorkspaceACL.getPermissions()
     );
   }
-  private async setupManagementWorkspace(savedObjectClient?: SavedObjectsClientContract) {
-    const managementWorkspaceACL = new ACL().addPermission(
-      [WorkspacePermissionMode.LibraryWrite, WorkspacePermissionMode.Write],
-      {
-        users: ['*'],
-      }
-    );
-    const DSM_APP_ID = 'dataSources';
-    const DEV_TOOLS_APP_ID = 'dev_tools';
-
-    return this.checkAndCreateWorkspace(
-      savedObjectClient,
-      MANAGEMENT_WORKSPACE_ID,
-      {
-        name: i18n.translate('workspaces.management.workspace.default.name', {
-          defaultMessage: 'Management',
-        }),
-        features: [
-          `@${DEFAULT_APP_CATEGORIES.management.id}`,
-          WORKSPACE_OVERVIEW_APP_ID,
-          WORKSPACE_UPDATE_APP_ID,
-          DSM_APP_ID,
-          DEV_TOOLS_APP_ID,
-        ],
-        reserved: true,
-      },
-      managementWorkspaceACL.getPermissions()
-    );
-  }
 
   public async setup(core: CoreSetup): Promise<IResponse<boolean>> {
     this.setupDep.savedObjects.registerType(workspace);
@@ -335,16 +305,6 @@ export class WorkspaceClientWithSavedObject implements IWorkspaceClientImpl {
         tasks.push(this.setupPublicWorkspace(scopedClientWithoutPermissionCheck));
       }
 
-      /**
-       * Setup management workspace if management workspace can not be found
-       */
-      const hasManagementWorkspace = savedObjects.some(
-        (item) => item.id === MANAGEMENT_WORKSPACE_ID
-      );
-      if (!hasManagementWorkspace) {
-        tasks.push(this.setupManagementWorkspace(scopedClientWithoutPermissionCheck));
-      }
-
       try {
         await Promise.all(tasks);
         if (tasks.length) {