Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Butterfly #284

Merged
merged 10 commits into from
Sep 15, 2024
Merged

Butterfly #284

merged 10 commits into from
Sep 15, 2024

Conversation

aniemeyer
Copy link
Collaborator

Added function Butterfly insertion

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 77.92208% with 34 lines in your changes missing coverage. Please review.

Project coverage is 76.38%. Comparing base (0810b52) to head (e8163c3).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
gap/PolygonalComplexes/modification.gi 59.52% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   76.35%   76.38%   +0.03%     
==========================================
  Files          61       63       +2     
  Lines       16210    16378     +168     
==========================================
+ Hits        12377    12511     +134     
- Misses       3833     3867      +34     
Files with missing lines Coverage Δ
gap/PolygonalComplexes/discs.gd 100.00% <100.00%> (ø)
gap/PolygonalComplexes/discs.gi 100.00% <100.00%> (ø)
gap/PolygonalComplexes/modification.gd 100.00% <100.00%> (ø)
gap/PolygonalComplexes/modification.gi 83.63% <59.52%> (-1.23%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Collaborator

@MeikeWeiss MeikeWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look nice! As you can see, I have a few minor comments.

gap/PolygonalComplexes/modification.gd Outdated Show resolved Hide resolved
gap/PolygonalComplexes/modification.gd Outdated Show resolved Hide resolved
gap/PolygonalComplexes/modification.gi Outdated Show resolved Hide resolved
gap/PolygonalComplexes/modification.gd Outdated Show resolved Hide resolved
gap/PolygonalComplexes/modification.gd Show resolved Hide resolved
gap/PolygonalComplexes/modification.gi Show resolved Hide resolved
gap/PolygonalComplexes/modification.gi Outdated Show resolved Hide resolved
Copy link
Collaborator

@MeikeWeiss MeikeWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@MeikeWeiss MeikeWeiss merged commit 20e2116 into gap-packages:master Sep 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants