Skip to content

Commit

Permalink
Drop first argument of RECOG.IsThisSL2Natural
Browse files Browse the repository at this point in the history
  • Loading branch information
fingolfin committed Oct 5, 2023
1 parent db7e9c6 commit 1af7a3e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions gap/projective/classicalnatural.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1469,7 +1469,7 @@ RECOG.GuessProjSL2ElmOrder := function(x,f)
return o;
end;

RECOG.IsThisSL2Natural := function(ri,gens,f)
RECOG.IsThisSL2Natural := function(gens,f)
# Checks quickly whether or not this is SL(2,f).
# The answer is not guaranteed to be correct, this is Las Vegas.
local CheckElm,a,b,clos,coms,i,isabelian,j,l,notA5,p,q,S,seenqm1,seenqp1,x;
Expand Down Expand Up @@ -3193,7 +3193,7 @@ function(ri, g)

# First check whether we are applicable:
if d = 2 then
if not RECOG.IsThisSL2Natural(ri,GeneratorsOfGroup(g),f) then
if not RECOG.IsThisSL2Natural(GeneratorsOfGroup(g),f) then
Info(InfoRecog,2,"ClassicalNatural: Is not PSL_2.");
return fail; # FIXME: fail = TemporaryFailure here really correct?
fi;
Expand Down
2 changes: 1 addition & 1 deletion tst/working/quick/bugfix.tst
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ gap> RecogniseGroup(SL(2,5));
# assumed to be true or false, but could be an FFE). This example used to
# trigger the error, which looked like this:
# Error, <expr> must be 'true' or 'false' (not an ffe)
gap> RECOG.IsThisSL2Natural(rec(), [ [ [ 0*Z(5), Z(5^2)^9 ], [ Z(5^2)^3, 0*Z(5) ] ], [ [ Z(5), 0*Z(5) ], [ 0*Z(5), Z(5)^3 ] ] ], GF(5^2));
gap> RECOG.IsThisSL2Natural([ [ [ 0*Z(5), Z(5^2)^9 ], [ Z(5^2)^3, 0*Z(5) ] ], [ [ Z(5), 0*Z(5) ], [ 0*Z(5), Z(5)^3 ] ] ], GF(5^2));
false

#
Expand Down

0 comments on commit 1af7a3e

Please sign in to comment.