Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Condense commands in gardenctl infra orphan list #476

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Condense commands in gardenctl infra orphan list #476

merged 2 commits into from
Dec 1, 2020

Conversation

jfortin-sap-zz
Copy link

What this PR does / why we need it:
Condense the command into a single verb gardenctl orphan (g orphan) with meaningful help message
Which issue(s) this PR fixes:
Fixes #475

Special notes for your reviewer:

Release note:

Condense the command into a single verb gardenctl orphan (g orphan) with meaningful help message

@jfortin-sap-zz jfortin-sap-zz requested a review from a team as a code owner November 30, 2020 19:24
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 30, 2020
@jfortin-sap-zz jfortin-sap-zz changed the title Condense commands Condense commands in gardenctl infra orphan list Nov 30, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 1, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 1, 2020
@neo-liang-sap
Copy link
Contributor

acoording to slack conversation with Jonathan , Daniel and I are good with this PR, i will perform merge, thanks Jonathan for this PR!

@neo-liang-sap neo-liang-sap merged commit 30c1445 into gardener-attic:master Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neo-liang-sap neo-liang-sap neo-liang-sap approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Condense commands in gardenctl infra orphan list
6 participants
@jfortin-sap-zz @neo-liang-sap @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot @jfortin-sap