Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clusterrole to include certificaterevocations #67

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

wwatson13
Copy link
Contributor

What this PR does / why we need it:
Experienced errors generating certs in soil for gardener dashboard webterminals

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Add certificaterevocations to clusterrole resources

Currently clusterrole does not include permissions for certificaterevocations.

This presented with errors when trying to create certificates for gardener dashboard webterminals
Adding certifcaterevocations to clusterrole
@wwatson13 wwatson13 requested a review from a team as a code owner March 19, 2021 17:31
@gardener-robot
Copy link

@wwatson13 Thank you for your contribution.

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2021

CLA assistant check
All committers have signed the CLA.

@gardener-robot gardener-robot added needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2021
@gardener-robot-ci-1
Copy link
Contributor

Thank you @wwatson13 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@MartinWeindel MartinWeindel added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 19, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 19, 2021
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 22, 2021
@MartinWeindel MartinWeindel merged commit 52eb685 into gardener:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants