Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Configuration of Container Runtimes #790

Merged
merged 5 commits into from
May 6, 2021
Merged

Support Configuration of Container Runtimes #790

merged 5 commits into from
May 6, 2021

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Aug 28, 2020 •
edited
Loading

What this PR does / why we need it:
This PR adds the functionality to configure Container Runtimes for Workers.
Note: This implementation reflects the current state of implementation in Gardener and it is still under discussion if we are going to merge this as is or if we want to wait until the API is finalized.

Screen Shot 2020-08-28 at 13 22 13

Screen Shot 2020-08-28 at 13 22 05

Which issue(s) this PR fixes:
Fixes #749

Special notes for your reviewer:

Release note:

Added support for configuring Container Runtimes for Workers via the Dashboard

@grolu grolu added kind/discussion Discussion (enaging others in deciding about multiple options) reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies labels Aug 28, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 28, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 28, 2020
@CLAassistant
Copy link

CLAassistant commented Sep 16, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@grolu grolu marked this pull request as draft September 16, 2020 14:37
@grolu grolu removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Sep 16, 2020
@gardener-robot gardener-robot added lifecycle/stale Nobody worked on this for 6 months (will further age) needs/review Needs review labels Nov 24, 2020
@petersutter
Copy link
Member

whats the status on this PR @grolu / is the API finalized?

@grolu
Copy link
Contributor Author

grolu commented Apr 23, 2021

Last time I checked with @danielfoehrKn it was not. @danielfoehrKn what is the current status?

@danielfoehrKn
Copy link

I think at this point we can go ahead with the Dashboard changes as there are no current plans to change the API.

@petersutter
Copy link
Member

thanks @danielfoehrKn

@grolu
Copy link
Contributor Author

grolu commented Apr 23, 2021

@petersutter I'll take care of this. Need to resolve merge conflicts and also adapt to new theming etc.

@grolu
Merge branch 'master' into enh/container_runtimes
47c75f9 
# Conflicts:
#	frontend/src/components/ShootWorkers/WorkerInputGeneric.vue
@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label May 4, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 4, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 4, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 5, 2021
@grolu grolu marked this pull request as ready for review May 5, 2021 13:56
@grolu grolu changed the title [DO NOT MERGE] Support Configuration of CRIs Support Configuration of Contsiner Runtimes May 5, 2021
@grolu grolu changed the title Support Configuration of Contsiner Runtimes Support Configuration of Container Runtimes May 5, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 6, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 6, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 6, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 6, 2021
holgerkoser
holgerkoser approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\lgtm

@grolu grolu merged commit 66fe8d1 into master May 6, 2021
@grolu grolu deleted the enh/container_runtimes branch May 6, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@petersutter petersutter Awaiting requested review from petersutter petersutter is a code owner

Assignees
No one assigned
Labels
kind/discussion Discussion (enaging others in deciding about multiple options) lifecycle/stale Nobody worked on this for 6 months (will further age) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support configuration of ContainerRuntimes
9 participants
@grolu @CLAassistant @petersutter @danielfoehrKn @holgerkoser @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot