Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy button for shoot name and seed name #986

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Add copy button for shoot name and seed name #986

merged 1 commit into from
Apr 12, 2021

Conversation

petersutter
Copy link
Member

@petersutter petersutter commented Mar 31, 2021 •
edited
Loading

What this PR does / why we need it:
This PR adds a copy button for the shoot name and seed name on the cluster list page.

Screenshot 2021-03-31 at 09 29 38

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

You can now copy the shoot name and seed name from the cluster list page

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 31, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 31, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 31, 2021
grolu
grolu approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 9, 2021
@petersutter petersutter merged commit d2e256f into master Apr 12, 2021
@petersutter petersutter deleted the enh/copy-btn branch April 12, 2021 11:22
@petersutter petersutter mentioned this pull request Apr 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grolu grolu grolu approved these changes

@holgerkoser holgerkoser Awaiting requested review from holgerkoser holgerkoser is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petersutter @grolu @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot