Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Configurable Retention Period for Delta Snapshots #640

Merged
merged 8 commits into from
Jul 27, 2023
Merged

Implement Configurable Retention Period for Delta Snapshots #640

merged 8 commits into from
Jul 27, 2023

Commits on Jun 28, 2023

  1. feat: Implement configurable retention period for delta snapshots 

    This commit introduces a new parameter, `delta-snapshot-retention-period`, in the `SnapshotterConfig`, allowing users to customize the retention period for delta snapshots.

The garbage collection function `GarbageCollectDeltaSnapshots` is modified to use this new setting, ensuring delta snapshots within the user-specified period are not deleted.
    @seshachalam-yv
    seshachalam-yv committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    f0b7c99 View commit details
    Browse the repository at this point in the history

  2. Fixed lint error

    @seshachalam-yv
    seshachalam-yv committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    e145040 View commit details
    Browse the repository at this point in the history

  3. Fixed failing unit test

    @seshachalam-yv
    seshachalam-yv committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    22871ee View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Refactor and improve unit tests for GarbageCollectDeltaSnapshots

    @seshachalam-yv
    seshachalam-yv committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    d0fbbe6 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Addressed PR feedback 

    - Improved grammar and phrasing for better readability.
- Fixed doc string for 'GarbageCollectDeltaSnapshots' function.
    @seshachalam-yv
    seshachalam-yv committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    736a67b View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Update snapshotter_test.go with additional safety checks 

    Co-authored-by: Aaron Francis Fernandes <[email protected]>

Update snapshotter_test.go with additional safety checks
    @seshachalam-yv
    seshachalam-yv committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    89483ec View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Shreyas Rao <[email protected]>
    @seshachalam-yv @shreyas-s-rao
    seshachalam-yv and shreyas-s-rao authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    cf8bbf4 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Addressed review feedback

    @seshachalam-yv
    seshachalam-yv committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    182d3dd View commit details
    Browse the repository at this point in the history