-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce persona-based docs #641
Conversation
Just a note, but the newly created manifest will need to also be added to one of the gardener/documentation manifests (probably in other-components.yaml) before it can appear on the website. |
@n-boshnakov You have pull request review open invite, please check |
Thanks @n-boshnakov, I added this component there. Are the etcd backup&restore maintainers otherwise OK to review the PR? |
Yes, they can review the PR. |
Is it OK to merge this PR (cc @shreyas-s-rao)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vlerenc thanks a lot for taking the time to restructure the docs
section. There are many more changes required with respect to the content of these docs, but this PR sets up the correct format/file structure to make those changes.
Other than one small nit, LGTM.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
We would like to introduce persona-based docs focussing on the already known release notes personas:
Special notes for your reviewer:
@n-boshnakov Can you please share your thoughts?
@shreyas-s-rao We agreed not to change too much (maybe anything), but I thought, maybe we can prepare some basics already, so that you have a better starting point later. Anyway, please check whether the small change is OK for you. Thanks in advance.
Release note:
None as ~30 PRs have/will be opened and the message would be the same everywhere.