Error handling for deletion of delta snapshots #793
+89
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@Shreyas-s14 Thank you for your contribution. |
gardener-robot
added
the
size/m
|
Thank you @Shreyas-s14 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
anveshreddy18
requested changes
Oct 18, 2024
gardener-robot
added
size/s
anveshreddy18
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
anveshreddy18
requested changes
Oct 22, 2024
| @@ -528,6 +528,51 @@ var _ = Describe("Snapshotter", func() { | |||
| Expect(len(list)).Should(Equal(3)) | |||
| }) | |||
| }) | |||
There was a problem hiding this comment.
You can also add a positive test case when there is no error in deleting snapshots.
| Expect(err).Should(HaveOccurred()) | ||
| }) | ||
| }) | ||
| Context("When the number of errors while deleting are greater than the threshold", func() { |
There was a problem hiding this comment.
Suggested change
| Context("When the number of errors while deleting are greater than the threshold", func() { | |
| Context("When the number of errors while deleting are greater than or equal to threshold", func() { |
| @@ -85,14 +86,15 @@ func (ssr *Snapshotter) RunGarbageCollector(stopCh <-chan struct{}) { | |||
| eod = now.Truncate(24 * time.Hour).Add(23 * time.Hour).Add(59 * time.Minute).Add(59 * time.Second) | |||
| trackingWeek = 0 | |||
| ) | |||
| // snapStream indicates the list of snapshot, where first snapshot is base/full snapshot followed by list of incremental snapshots based on it. | |||
There was a problem hiding this comment.
You can move this comment to above as snapStream is used there but defined here.
Shreyas-s14
force-pushed
the
error-handling-delta-deletion
branch
from
a0fee5d
to
8aea8c3
Compare
gardener-robot
added
size/m
anveshreddy18
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR changes the error handling for deletion of delta snapshots by replacing the current implementation with concatenation of errors using the errors.Join() method upto a threshold of 5. The process of continues with the deletion of the rest of the "deletable" delta snapshots even when an error is encountered, instead of halting the process. When the number of errors becomes greater than the threshold, it errors out for the current cycle.
Which issue(s) this PR fixes:
Fixes #652