Little improvements in etcd_bootstrap_script.sh #28
Conversation
gardener-robot
added
needs/review
There was a problem hiding this comment.
@StenlyTU thanks for your PR. I tested it locally and saw that etcd container throws the following error log:
standard_init_linux.go:228: exec user process caused: exec format error
Can you please check this? Thanks.
| echo $RET > $VALIDATION_MARKER | ||
| exit $RET | ||
| arch=$(uname -m) | ||
| if [ $arch = "aarch64" ] || [ $arch = "arm64" ]; then |
There was a problem hiding this comment.
Can you also enclose $arch in double quotes? This is usually done to prevent gobbling and word splitting.
| "Successful") | ||
| echo "Bootstrap preprocessing end time: $(date)" | ||
| start_managed_etcd | ||
| break ;; |
There was a problem hiding this comment.
This is unreachable line and should ideally be removed. Call to start-managed-etcd function has exit as the last statement which means break will never be called.
I think you have ARM based chipset. Can you check if this is not an issue with using the wrong image on built for another architecture? |
|
@StenlyTU we haven't heard anything from you from a while. We have started work on #16, which would invalidate any changes you've made in this PR. So I would vote in favour of closing this PR since the changes made here don't bring any functional improvement, for the cost of making a new release of the etcd-custom-image for the same etcd version being used within gardener, given that we will be restructuring the repo, code and releases. |
gardener-robot
added
the
status/closed
What this PR does / why we need it:
Improve Indentation and readability.
Special notes for your reviewer:
Release note: