Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables configurable in values-file of Helm #139

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

mganter
Copy link
Contributor

@mganter mganter commented Nov 16, 2020

What this PR does / why we need it:

This change allows us to set environment variables to the deployment. For example we could use http_proxy.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Environment variables can now be set via values.yaml

@gardener-robot
Copy link

@mganter Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 16, 2020
@gardener-robot-ci-3
Copy link
Contributor

Thank you @mganter for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for your contribution!

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 16, 2020
@MartinWeindel
Copy link
Member

/ok-to-test

@gardener-robot gardener-robot added the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 16, 2020
@MartinWeindel MartinWeindel merged commit bf00825 into gardener:master Nov 16, 2020
@mganter
Copy link
Contributor Author

mganter commented Nov 16, 2020

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants