support chain of credential providers for AWS #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
MartinWeindel
force-pushed
the
aws-external-creds
branch
from
8cc054e
to
336e7fe
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
MartinWeindel
force-pushed
the
aws-external-creds
branch
from
336e7fe
to
cd04284
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
|
@zjj2wry Have you time to test this PR before we are releasing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For AWS Route53 support is added for the chain of credential providers.
If the provider
Secretcontains the data keyAWS_USE_CREDENTIALS_CHAIN, no credentials need to be specified.Instead the chain of credential providers is used to search for credentials in environment variables, shared credential file, and EC2 Instance Roles.
This PR is a slightly adapted variant of the PR #143.
Thanks to @zjj2wry!
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: