Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message for 'no domain matching zones' #158

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
The error message for 'no domain matching zones' now includes a list valid base domains of the available zones.
Additionally the status fields for zones and domains are updated on error.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

improve error message for 'no domain matching zones'

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 12, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 12, 2021
@MartinWeindel MartinWeindel merged commit ddc78ae into master Mar 15, 2021
@MartinWeindel MartinWeindel deleted the improve-no-domain-matching-zones branch March 15, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants