fix deletion handling for inconsistently/wrongly disappeared source object #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
mandelsoft
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
On startup of the source controller, we saw inconsistent results from the client lister. A source object has disappeared from the list results, although it was not deleted and still existing. As a consequence the slave DNS entry was deleted and recreated some seconds later. But because of negative caching, secondary DNS server did not find the DNS record for a much longer time.
A bug was fixed with apimachinery
v0.18.7Kube-apiserver: fixed a bug returning inconsistent results from list requests which set a field or label selector and set a paging limit. As this component used versionv0.18.6, this could be the root cause.The K8s dependencies have been updated to
v0.18.18.Additionally we added some safeguard to the
Deletedreconciliation of the source object.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: