Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Alicloud #283

Closed
wants to merge 20 commits into from
Closed

Support Alicloud #283

wants to merge 20 commits into from

Conversation

knightXun
Copy link

Support Alicloud

@knightXun knightXun requested a review from a team as a code owner September 8, 2020 05:11
@gardener-robot
Copy link

@knightXun Thank you for your contribution.

@CLAassistant
Copy link

CLAassistant commented Sep 8, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rfranzke
Copy link
Member

rfranzke commented Sep 8, 2020

/invite @jia-jerry @minchaow @EmoinLanyu

@gardener-robot gardener-robot added the needs/review Needs review label Sep 8, 2020
jia-jerry
jia-jerry suggested changes Sep 8, 2020
View reviewed changes
acre.yaml Outdated Show resolved Hide resolved
components/gardencontent/seeds/provider/alicloud/seed.yaml Outdated Show resolved Hide resolved
components/gardener/extensions/deployment.yaml Show resolved Hide resolved
jia-jerry
jia-jerry suggested changes Sep 16, 2020
View reviewed changes
components/etcd/cluster/chart/templates/statefulset-etcd.yaml
@@ -173,4 +173,4 @@ spec:
- "ReadWriteOnce"
resources:
requests:
storage: 10Gi
storage: 20Gi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will affect other existing landscapes. Can you make it configurable?

components/gardencontent/profiles/provider/alicloud/iaas.yaml
- id: ubuntu_18_04_x64_20G_alibase_20200717.vhd
name: cn-shanghai
version: 18.4.20200228
- name: coreos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove CoreOS, it is not maintained.

components/gardencontent/seeds/manifests/seed_manifests.yaml
@@ -66,6 +66,8 @@ seedSpec:
services: (( configValues.seed.networks.services ))
shootDefaults: (( configValues.seed.shootDefaultNetworks || { "pods" = "100.96.0.0/11", "services" = "100.64.0.0/13" } ))
taints: (( configValues.config.mode == "soil" ? [{ "key" = "seed.gardener.cloud/invisible" }, { "key" = "seed.gardener.cloud/protected" }] :~~ ))
volume:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make it configurable. Don't affect other providers.

components/gardencontent/seeds/manifests/seed_manifests.yaml
@@ -66,6 +66,8 @@ seedSpec:
services: (( configValues.seed.networks.services ))
shootDefaults: (( configValues.seed.shootDefaultNetworks || { "pods" = "100.96.0.0/11", "services" = "100.64.0.0/13" } ))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use 100.XXXX CIDR in AliCloud

components/gardener/extensions/deployment.yaml
@@ -349,6 +382,7 @@ extension_manifests:
image:
repo: (( version.image_repo || ~~ ))
tag: (( version.image_tag || ~~ ))
imageVectorOverwrite: (( version.imageVectorOverwrite || ~~ ))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you change azure?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point..

@gardener-robot gardener-robot added lifecycle/stale Nobody worked on this for 6 months (will further age) needs/changes Needs (more) changes and removed needs/review Needs review labels Nov 16, 2020
@gardener-robot gardener-robot added needs/rebase Needs git rebase and removed needs/rebase Needs git rebase labels Feb 9, 2021
@gardener-robot
Copy link

@knightXun You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added needs/rebase Needs git rebase and removed needs/rebase Needs git rebase labels Apr 12, 2021
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/rebase Needs git rebase and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels May 19, 2021
@gardener-robot
Copy link

@knightXun You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Jun 17, 2021
@gardener-robot
Copy link

@knightXun You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jul 8, 2021
@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Jul 30, 2021
@gardener-robot
Copy link

@knightXun You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added needs/rebase Needs git rebase and removed needs/rebase Needs git rebase labels Aug 6, 2021
@gardener-robot
Copy link

@knightXun You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Aug 6, 2021
@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Aug 31, 2021
@Diaphteiros Diaphteiros linked an issue Nov 5, 2021 that may be closed by this pull request
Add AliCloud to garden-setup #643
Open
@ThormaehlenFred
Copy link

This feature should be used for our next pentest comprising Alicloud.

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Nov 22, 2021
@gardener-robot
Copy link

@knightXun You need rebase this pull request with latest master branch. Please check.

@Diaphteiros
Copy link
Contributor

Implemented in #771

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia-jerry jia-jerry jia-jerry requested changes

@EmoinLanyu EmoinLanyu Awaiting requested review from EmoinLanyu

@minchaow minchaow Awaiting requested review from minchaow

Assignees
No one assigned
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/changes Needs (more) changes needs/rebase Needs git rebase status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add AliCloud to garden-setup
7 participants
@knightXun @gardener-robot @CLAassistant @rfranzke @ThormaehlenFred @Diaphteiros @jia-jerry