Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong name for repository in extension deployment #294

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Wrong name for repository in extension deployment #294

merged 1 commit into from
Sep 15, 2020

Conversation

dergeberl
Copy link
Contributor

@dergeberl dergeberl commented Sep 14, 2020

What this PR does / why we need it:

Fix repository value name in the extension deployment.

The image repository is set to repo, but the helm charts use repository for the variable.
Example: https://github.com/gardener/gardener-extension-os-coreos/blob/master/charts/gardener-extension-os-coreos/values.yaml#L2

Which issue(s) this PR fixes:

Special notes for your reviewer:

Release note:

Fixed a bug that prevented the images of the Gardener extensions from being overwritten.

@dergeberl dergeberl requested a review from a team as a code owner September 14, 2020 13:41
@gardener-robot
Copy link

@dergeberl Thank you for your contribution.

@knightXun
Copy link

that's awesome

Copy link
Contributor

@Diaphteiros Diaphteiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you very much!

@Diaphteiros Diaphteiros merged commit 5da6f74 into gardener:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants