Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ingress clusterrole #306

Merged
merged 1 commit into from
Sep 23, 2020
Merged

fix ingress clusterrole #306

merged 1 commit into from
Sep 23, 2020

Conversation

dergeberl
Copy link
Contributor

What this PR does / why we need it:

Fix the ingress ClusterRole for ingresses/status in API group networking.k8s.io.
In the new ingress version (from #279) the apiGroup networking.k8s.io is required for ingresses/status in the ClusterRole

W0922 14:25:19.862404       7 status.go:279] error updating ingress rule: ingresses.networking.k8s.io "apiserver-ingress" is forbidden: User "system:serviceaccount:kube-system:nginx-ingress" cannot update resource "ingresses/status" in API group "networking.k8s.io" in the namespace "garden"

Which issue(s) this PR fixes:

Special notes for your reviewer:

Release note:

Fixed a bug in the ingress ClusterRole

@dergeberl dergeberl requested a review from a team as a code owner September 22, 2020 14:51
@gardener-robot
Copy link

@dergeberl Thank you for your contribution.

Diaphteiros
Diaphteiros approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@Diaphteiros Diaphteiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Sep 23, 2020
@Diaphteiros Diaphteiros merged commit 2d1a1d1 into gardener:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Diaphteiros Diaphteiros Diaphteiros approved these changes

Assignees
No one assigned
Labels
reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dergeberl @gardener-robot @Diaphteiros